strukturag / libde265

Open h.265 video codec implementation.
Other
1.7k stars 457 forks source link

dec265 program built even after specifying --disable, .pc file missing version #408

Closed govindrai closed 1 year ago

govindrai commented 1 year ago

Running the below produces a working dec265 binary. it also produces hdrcopy (not sure if it should be producing that as well).

curl -L https://github.com/strukturag/libde265/releases/download/v1.0.11/libde265-1.0.11.tar.gz | \
    tar zx && \
    cd libde265-1.0.11 && \
    ./autogen.sh && \
    ./configure --disable-dec265 --disable-sherlock265 && \
    mkdir build && \
    cd build && \
    cmake .. && \
    make && \
    make install

Also the pkg-config file generated is missing version information

       │ File: libde265.pc
───────┼─────────────────────────────────────────────────────────────────────────
   1   │ prefix=/govind
   2   │ exec_prefix=${prefix}
   3   │ libdir=${exec_prefix}/lib64
   4   │ includedir=${prefix}/include
   5   │ 
   6   │ Name: libde265
   7   │ Description: H.265/HEVC video decoder.
   8   │ URL: https://github.com/strukturag/libde265
   9   │ Version: 
  10   │ Requires: 
  11   │ Libs: -lde265 -L${libdir}
  12   │ Libs.private:  -lstdc++
  13   │ Cflags: -I${includedir}
farindk commented 1 year ago

You are using both autotools build and cmake build at the same time. That makes no sense. Use only one of them. E.g.

curl -L https://github.com/strukturag/libde265/releases/download/v1.0.11/libde265-1.0.11.tar.gz | \
    tar zx && \
    cd libde265-1.0.11 && \
    ./autogen.sh && \
    ./configure --disable-dec265 --disable-sherlock265 && \
    make

Output of the version into the libde265.pc was fixed in 93a3051153c3cbdc1ed99f02a8de445854d87d55.