search

strukturag / libheif

libheif is an HEIF and AVIF file format decoder and encoder.
Other
1.71k stars 298 forks source link

Use SVT-AV1 PSY fork with --tune 4 #1285

Closed gitoss closed 1 month ago

gitoss commented 1 month ago

The PSY fork of SVT-AV1 features a new --tune 4 which is designed to improve still picture (i.e. AVIF) encoding:

"--tune 4 - A new Tune called Still Picture has been introduced for AVIF encoding, with promising gains observed over aomenc, aomenc 4:4:4, and mainline SVT-AV1" https://github.com/AOMediaCodec/libavif/releases

It would be nice to have libheif use this fork (with third-party/svt.cmd) and tune out of the box (if SVT-AV1 encoder is selected).

There are no indepennded benchmarks / image comparisons though as far as I can tell. https://github.com/gianni-rosato/svt-av1-psy/commit/393cf6dfe4d5315370ad429e891f784940ed7926

bradh commented 1 month ago

I think we should stick with the mainline, given comments like: https://github.com/gianni-rosato/svt-av1-psy/commit/393cf6dfe4d5315370ad429e891f784940ed7926#diff-6687059c745f98a928cbc3ee5803db4aafecc61e405a894b3028aa56ab67a87fR4630-R4631

I'm also -1 on use of experimental forks in general.

farindk commented 1 month ago

@gitoss Thanks for making us aware that such a development branch exists. We want to base libheif on the stable branches of the codecs, but you are of course free to compile it with whatever version of Svt-av1 as you like to be at the cutting edge.