search

strukturag / libheif

libheif is an HEIF and AVIF file format decoder and encoder.
Other
1.61k stars 293 forks source link

Fails to find rav1e #429

Open yurivict opened 3 years ago

yurivict commented 3 years ago

This line https://github.com/strukturag/libheif/blob/master/CMakeLists.txt#L67 fails to find rav1e.

rav1e-0.4.0 is installed. https://github.com/xiph/rav1e

What is wrong?

FreeBSD 12.2

VVD commented 3 years ago 
-- Found RAV1E 
CMake Warning (dev) at /usr/local/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:426 (message):
  The package name passed to `find_package_handle_standard_args` (RAV1E) does
  not match the name of the calling package (Rav1e).  This can lead to
  problems in calling code that expects `find_package` result variables
  (e.g., `_FOUND`) to follow a certain pattern.
Call Stack (most recent call first):
  cmake/modules/FindRav1e.cmake:20 (find_package_handle_standard_args)
  CMakeLists.txt:67 (find_package)
This warning is for project developers.  Use -Wno-dev to suppress it.

-- Found RAV1E: /usr/local/include/rav1e
HEIF decoder, libde265: found
HEIF encoder, x265: found
AVIF encoder, aom: found
AVIF decoder, aom: found
AVIF encoder, rav1e: found
AVIF decoder, dav1d: found
VVD commented 3 years ago 
Shared Libs required:
        libde265.so.0
        libintl.so.8
        libglib-2.0.so.0
        libgobject-2.0.so.0
        libaom.so.2
        librav1e.so.0
        libx265.so.192
        libdav1d.so.5
        libgdk_pixbuf-2.0.so.0
yurivict commented 3 years ago

Thanks!

VVD commented 3 years ago

Added the ability to disable RAV1E and DAV1D: patch-CMakeLists.txt

yurivict commented 3 years ago

Could you please commit the patch above? Could you also please add the REQUIRED keyword to find_package() calls?

Thanks!

farindk commented 3 years ago

Thanks for the patch. I have added it. I am not sure whether we should add REQUIRED because it is also a nice behavior that we can simply leave all codec options ON and the unavailable ones are disabled automatically.