search

strukturag / libheif

libheif is an HEIF and AVIF file format decoder and encoder.
Other
1.76k stars 302 forks source link

There is no version info in libheif.dll #916

Open anatoliiKumunzhiev opened 1 year ago

anatoliiKumunzhiev commented 1 year ago

Hi! I noticed that there is no version info in libheif.dll file. image

I checked it for libheif-1.12.0 and version which is installed by vcpkg (libheif-1.16.2).

At the same time I can see this information for old versions (for example 1.10.0.0). image

Version information is critically important for the update procedures.

So, could you check it pls and approve it, if it is an issue? (Actually, there is the same situation with libde265.dll, there is no version info for last version)

farindk commented 1 year ago

It might be that the old automake build did this, but it has to be done manually in cmake. I found this: https://stackoverflow.com/questions/6693100/how-to-generate-windows-dll-versioning-information-with-cmake

anatoliiKumunzhiev commented 1 year ago

Thanks a lot for the answer! I have tried to add version.rc.in and change CMakeLists to fix it (as described here: https://stackoverflow.com/questions/6693100/how-to-generate-windows-dll-versioning-information-with-cmake ), but it doesn't solve a problem in my case. I suppose, I do something wrong. Could you show pls, what do I need to change manually in cmake to get a version info in dll? And tell pls, do you plan to fix it for vcpkg installation? This would solve my problem, if so.

farindk commented 1 year ago

I will look at it when I have time. The vcpkg is not built by me, but I'm sure they will update it when I have a new release.

anatoliiKumunzhiev commented 1 year ago

Could you tell pls, when do you plan to check it (approximately)? Week, or month, or, maybe next version? I ask you, because it is quite important for me and I would like to decide what to do in this case. I mean, if this is too long for me, I need to look for another way to solve my problem. Thank you!