search

strukturag / nextcloud-spreedme

Spreed.ME Nextcloud app
https://www.spreed.me
GNU Affero General Public License v3.0
56 stars 26 forks source link

Allow to configure the app via web interface #39

Closed leonklingele closed 8 years ago

leonklingele commented 8 years ago

.. only if config/config.php does not exist.

fancycode commented 8 years ago

How does this work with the packaged version on the Spreedbox? Will the corresponding fields in the UI be still available/editable?

leonklingele commented 8 years ago

No changes are required for the packaging.

If config/config.php exists, we will use it instead of querying the database. OwnCloudConfig.js is no longer required for the Spreedbox and can simply be deleted.

longsleep commented 8 years ago

If config/config.php exists, we will use it instead of querying the database.

What about the user inferface? Does it detect that the configuration is not in the database?

OwnCloudConfig.js is no longer required for the Spreedbox and can simply be deleted.

What happens if the file is still there? No problem?

leonklingele commented 8 years ago

What about the user inferface? Does it detect that the configuration is not in the database?

I suggest to test the user interface yourself.

What happens if the file is still there? No problem?

No problem. We will load it if it exists.

leonklingele commented 8 years ago

Sorry, I updated the PR again. I guess this can be reviewed now.

longsleep commented 8 years ago

Made some comments. Otherwise lgtm :+1 - but please make sure to squash before merge.

leonklingele commented 8 years ago

Merged in 7d9843d8ba0ffeb687913e05ca9259cf984d4664.

tedd77 commented 8 years ago

Installed Spreed-webrtc from repository

  1. Should I enable https in /etc/spreed/webrtc.conf the server cannot be restarted it fails until removing the https option.
  2. I cannot prevent direct access to the spreed server from outside nextcloud so anyone can access http://serverip:8080
  3. Any progress on having the users list of nextcloud displayed on spreed ?

could someone advise ?

leonklingele commented 8 years ago

Hi @tedd77,

  1. Should I enable https in /etc/spreed/webrtc.conf

No, just follow the instructions here: https://github.com/strukturag/nextcloud-spreedme#installation--setup-of-this-app As you’re using the packaged version of spreed-webrtc, you need to add:

[http]
; Full path to directory where to find the server web assets.
root = /usr/share/spreed-webrtc-server/www
  1. I cannot prevent direct access to the spreed server from outside nextcloud so anyone can access http://serverip:8080

This should only happen if you listen = 0.0.0.0:8080 instead of ´listen = 127.0.0.1:8080`

  1. Any progress on having the users list of nextcloud displayed on spreed ?

No, but Spreed.ME will be integrated into Nextcloud more deeply with https://github.com/nextcloud/spreed

tedd77 commented 8 years ago

@leonklingele Thanks a lot for your reply. All is well now, http, https and security no direct access. however the file /var/www/nextcloud/apps/spreedme/config.php should have const SPREED_WEBRTC_ORIGIN = ''; (no ip neither port)

also -----------------/etc/spreed server.conf---- [http] ; HTTP listener in format ip:port.

listen = 127.0.0.1:8080

One last request, in order to access it from public ip, I need to know what port on the firewal to open and which protocol. Do I need to set Turn server ?

tedd77 commented 8 years ago

Update Turn is required and port 8443/UDP too

leonklingele commented 8 years ago

In order to get https working with Spreed WebRTC, you should set up your web server (most likely nginx or Apache) as a reverse proxy. Please follow the instructions for nginx or Apache

tedd77 commented 8 years ago

@leonklingele is there a package for Centos 7 without the hassle to compile? if so how to add the repository to the centos machine.

leonklingele commented 8 years ago

Currently we only provide packages for Ubuntu: https://github.com/strukturag/spreed-webrtc/wiki/Ubuntu-Repository