Save PDF instead of download only

elvirusDE commented 3 years ago

Could it be possible to save the annotated PDF to the original file instead of being able to only download it? Like a "save"-button in the secondary toolbar right next to the download button. That would be awesome.

We are using this plugin to annotate documents in the nextcloud for some users. They have to be able to see the annotations. So the current workflow is: The annotator opens a PDF file from a user, annotates it, then downloads it. Then he deletes the original file and uploads the annotated file. That could be much simpler if there were a save button which just combines the annotations and the pdf and saves it to the path of the original file.

Is this somehow possible?

Best regards, elvirus

fancycode commented 3 years ago

If the annotated file replaces the original PDF, the annotations can not be removed in the future. Maybe another solution would be a way to save the annotated PDF in Nextcloud with a different filename?

elvirusDE commented 3 years ago

Ok, good point. So with a press on the save button the user should be prompted with a text input to enter a file name. The original file name could be inserted as a default placeholder. With that mechanism in place, the user could decide, wether he wants to replace the original file or make a copy of it. In our use case we do want the original file to be replaced and we don't care if the annotations could not be removed. It is about a teacher correcting her pupils works.

If you cannot implement this functionality at the moment, could you point me in the right direction so that I could start developing it? Maybe with some helpful comments from your side we could get it working...

fancycode commented 3 years ago

The combined file is available on the server at https://github.com/strukturag/pdfdraw/blob/230441263f72a589f334e3e04927f4c41c12d7f8/server/server.js#L813

Here an upload to Nextcloud would have to be implemented. I don't know about the necessary APIs though.

Another way would be to add an API to Nextcloud that downloads the combined file from the server and stores it internally. For that I would have to read API documentation first, too.

szaimen commented 3 years ago

This feature would be really great 👍

lbdroid commented 3 years ago

There is no need to rename the file when saving. Nextcloud keeps old versions (3-dots button --> details --> versions), so the original file will always remain available.

lbdroid commented 3 years ago

I need to add 2 cents to this request, it is an ABSOLUTELY CRITICAL feature that it will be able to save-IN-PLACE (i.e., withOUT renaming). In fact, the "download" option can be removed altogether -- it is completely unnecessary since Nextcloud can provide download functionality after saving.

The problem with being restricted to download-only, is that it doesn't offer any utility that can't be done better with a standalone pdf annotator. Trying to use this within Nextcloud means annotating the file, downloading, and then uploading. Using a standalone annotator means only changing the order of that -- download, then annotate, then upload -- no benefit here.

Following a successful save, it should also clear all annotations for that document from the database, having already been applied to the document.

lbdroid commented 3 years ago

@fancycode - Here's the easy sauce;

curl -T somefile.pdf -H 'X-Requested-With: XMLHttpRequest' -H "User-Agent: Mozilla/5.0 (Android) Nextcloud-android" --cookie 'the cookie' https://nextcloud.your.tld/remote.php/webdav/path/to/file.pdf

** Note that that creates a PUT request.

The user-agent header there is to bypass a cross-site request forgery check in lib/Connector/Sabre/Auth.php The cookie comes from the connection headers https://github.com/strukturag/pdfdraw/blob/master/server/server.js#L861 -- i.e. "socket.handshake.headers".

And every time you upload the file like that, its a new version with old versions still recoverable in the "versions" menu, so always keep the same name.

The only data missing in server.js to accomplish this is the "path/to/" component of the file path, which I'm sure is easy enough at the frontend code to find and pass along to the backend.

PJSymes commented 3 years ago

This feature would be really great 👍

This is an important feature that would allow me to use this App as a replacement PDF reader on tablets whilst keeping the documents in a centralised location

szaimen commented 3 years ago

I suggest you try this fork as it has many missing features already done: https://gitlab.com/nextcloud-other/nextcloud-annotate

PJSymes commented 3 years ago

Thanks for this this is exactly what I was looking for. :-)

From: szaimen @.***> Sent: 02 September 2021 15:52 To: strukturag/pdfdraw Cc: Pete Symes; Comment Subject: [Marketing] Re: [strukturag/pdfdraw] Save PDF instead of download only (#6)

    CAUTION: This email originated outside of Kinly.

Please help keep your organization and partners safe, think before you click.

I suggest you try this fork as it has many missing features already done: https://gitlab.com/nextcloud-other/nextcloud-annotate

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/strukturag/pdfdraw/issues/6#issuecomment-911772353, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AVOSGNAUFA7AAHZOY6OJ373T76FT7ANCNFSM4U3LBBRQ. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

This email has been scanned by the Symantec Email Security.cloud service. For more information please visit http://www.symanteccloud.com

strukturag / pdfdraw

Save PDF instead of download only #6