Attribution

[danieldegroot2]

Hey John,

I noticed the following;

• The app has no copyright and license links
• The desktop version has no attribution at all

Make sure you have proper attribution for all map layers; For copyright, see https://www.openstreetmap.org/copyright for OpenStreetMap for example. For license, see ex. CreativeCommons website. You can also use https://chooser-beta.creativecommons.org/ to get some basic text (to display elsewhere).

[strukturart]

I have expanded the readme with the necessary licenses and attributions are shown briefly in the app and in the desktop version in the footer. I do that because the devices have a very small screen.

do you think that's enough?

[danieldegroot2]

Solely map attribution is needed. You can additionally attribute OpenStreetMap in your repository's README.md but this is optional. You do not have to mention "OpenStreetMap is a trademark of the OpenStreetMap Foundation. o.map is not endorsed by or affiliated with the OpenStreetMap Foundation." in your LICENSE or Licenses section (this should be used for your repository's license, the section in your README can also be used for software licenses if there's any); this is already specified on the copyright page, which should be linked from mentioned map attribution. If any data from third-party apps are stored on the user's browser/device (client), you can tell people in your own privacy police / terms page if you have one (for OpenStreetMap, this shouldn't be the case).

I do not see any changes to the website in the referenced commits, but do see attribution is hidden in the map menu and/or in the web console. I can't seem to open the menu on clicking the 'menu' button in the bottom center. I also only see "Leaflet" (only the leaflet attribution, not additional attribution) for a brief moment on Desktop (on Desktop you should show it forever, you should be able to code for mobile seperate though may take longer). As for the mobile attribution, if you asked @matkoniecz -who looks at site's attribution- they would like you to show it permanently somehow (otherwise, I would recommend putting it in a button or in the menu as you may have done), but best is to ask the Licensing Working Group.

On Desktop, it should really look more like this image on the copyright page -with the leaflet attribution kept of course-, as it's most important to display directly on the map where it can be immediately seen by anyone;

The additional attribution in the menu is welcome ofc.

[strukturart]

the dumbphone for which the app is intended only has keys, which is why the browser version is only key only. with enter you get to the menue for the layers switch etc. attribution now stays visible at > 600px viewport.

[danieldegroot2]

Minor suggestions:

• The weather layer doesn't show any additional attribution when toggled on. example (unfortunately attribution for DWD is partially hidden by advertisement; there's also bottom advertisement which you can collapse)
• It would be nice to show the copyright links for OpenTopoMap, OpenStreetMap ( https://www.openstreetmap.org/copyright ) and possibly Esri itself (at least on Desktop, as you always see them there). They are ok without one generally, especially the individual satellite sources beside Esri.
• There's two copyright icons in the first part of the OpenTopoMap attribution.
• On satellite, the long attribution text is for a fraction hidden by the menu icon. You could try to position the attribution just above the menu icon, so the UI remains consistent.

Other minor suggestions:

• The menu should remember/highlight which layer you have selected, Currently, when OpenStreetMap (default) or Satellite is selected OpenTopoMap is always highlighted on opening the menu because it is at the top.
• The weather layer is a toggle. maybe there should be a visual indicator to show whether you have it toggled on or off.
• The weather layer flickers every second or so. Is this to update it? If so, it may be better to only update every five minutes (or with a refresh button/key).
• The menu icon at some point changed to a white square for me, so the image must have failed to load. I could try to reproduce it, but it's very minor as on reload it loads again. (Edit: I now have elements going white on various websites, so I think I can safely assume this last issue is only on my end and not on yours. I hope this resolves itself, it is likely zoom-related.)

[LolloDev5123]

Will the attribution fit on a 240x320 screen?

[danieldegroot2]

Will the attribution fit on a 240x320 screen?

It would fit, though

• they may need/have a different display method than leaflet's attribution container for this size.
• additional attribution may take up too much space, clearly.
• as mentioned, they may ask LWG what display options are prefered.

When you search your prefered browser you should find something like this btw (these examples may no longer be available); ('xMaps')

('Hyves')

(note, especially when shown on the map itself, low contrast with background makes it less visible; with modern software it's easier to adjust this to now existing -optional- accessibility standards (a.o. WCAG), which require sufficient contrast for those with less eyesight. These optional standards are usually considered a very low priority issue.)

[danieldegroot2]

---

Feel free to look at good attribution examples for inspiration (not saying they are perfect).

[strukturart]

I have now added the attributions and added links to the sources in the menu. the desktop is only a showcase for the kaiOs users to show the functionality of the app. there are far better websites such as: umap which i use myself to plan tracks. I realize that I was a bit lax about specifying the data sources, but I think it should be ok now. please install the app on a kaiOs device then you will see how tight the space on the device is and you have to make some compromises.