search

strukturart / passport

At times it is practically fast to access digital train / airplane qrcode tickets to showcase at a check-in. I wrote an app for that. All image files in a defined order (/passport/) are listed and displayed via enter.
MIT License
9 stars 2 forks source link

bottom and right border to big #3

Closed vlycop closed 3 years ago

vlycop commented 3 years ago

Hello. Thanks a lot for this I think there is a math error in the qrcode picture generators. Specifically the part that generate the white border around it.

I've noticed that while the top and left border look to always be the same size, the bottom and right border grow based on the size of the qrcode.

This issue have become apparent when scanning European covid certificates, which are really big. Almost 1/5 of the screen is white.

I obviously can't send you this one, but here is an example of a small increase.

It doesn't look to be linear to the total size.

Lorem1

strukturart commented 3 years ago

you can try the app again to test whether my changes have improved a bit

vlycop commented 3 years ago

Sadly no :( The bottom and right border look the same, while the left and top one now is only 1 px wide tfrt

strukturart commented 3 years ago

do you have any programming skills? if so, can you please try out the values?

https://github.com/strukturart/passport/blob/71e1d45ef5d6b654b15c219c7bbdaa6774672190/application/index.js#L169

vlycop commented 3 years ago

I'm sorry, what do you mean by "try out" ? This value '800' is already what is setted on the app right now Do you want me to play with it and see what's look better?

I feel like changing a size value won't solve what look like a padding issue.

I have little to no skilz in js, and in general i'm limited to small scripting. But i'm willing to help where i can :D Please clarify what you wish me to do :+1:

strukturart commented 3 years ago

I don't know exactly where I can influence the behavior of the size of the generated qr code. i can change the image size and padding, but i need your help to test it. It looks good for me now, but I can't scan a covid certificate with my phone because I don't have a printout and the qr code on the screen is too complex.

strukturart commented 3 years ago

@vlycop did you test the new version?

vlycop commented 3 years ago

Very sorry, am in not in a place with access to a computer ... Please give me until Tuesday