search

struts-community-plugins / struts2-jquery

Struts2 jQuery Plugin
Apache License 2.0
83 stars 49 forks source link

Deprecated use of isFunction #342

Closed nikosdimitrakas closed 1 year ago

nikosdimitrakas commented 1 year ago

There is a call the isFunction at line 92 in jquery.subscribe.js that according to JQuery-Migrate is deprecated. According to https://github.com/jquery/jquery-migrate/blob/main/warnings.md the solution is Replace any use of jQuery.isFunction( x ) with typeof x === "function"

lukaszlenart commented 1 year ago

but as far I understand this is a JQuery library not a custom thing in the plugin? I wouldn't change what JQuery offers and rather upgrade to the latest version if available - @jogep @sdutry any opinion?

jogep commented 1 year ago

@lukaszlenart this is not part of jQuery itself. Was a custom third party plugin which I extended a while ago.

https://github.com/struts-community-plugins/struts2-jquery/blob/release/5.0.x/struts2-jquery-plugin/src/main/resources/template/js/plugins/jquery.subscribe.js

Will check if I can provide this for the next version.

jogep commented 1 year ago

Fixed with new release 5.0.3