search

struts-community-plugins / struts2-jquery

Struts2 jQuery Plugin
Apache License 2.0
82 stars 50 forks source link

Question: Why are generated minified javascript files part of the git repository? #66

Closed sdutry closed 7 years ago

sdutry commented 8 years ago

Is there a reason why the minified javascript files, which are generated with each build (during the package phase), are part of the git repository?

module: struts2-jquery-plugin resources:

src/main/resources/template/js/struts2/jquery.struts2.min.js
src/main/resources/template/js/struts2/jquery.ui.struts2.min.js

src/main/resources/template/js/base/accordion.min.js
src/main/resources/template/js/base/autocomplete.min.js
src/main/resources/template/js/base/button.min.js
src/main/resources/template/js/base/core.min.js
src/main/resources/template/js/base/datepicker.min.js
src/main/resources/template/js/base/dialog.min.js
src/main/resources/template/js/base/draggable.min.js
src/main/resources/template/js/base/droppable.min.js
src/main/resources/template/js/base/effect.min.js
src/main/resources/template/js/base/effect-blind.min.js
src/main/resources/template/js/base/effect-bounce.min.js
src/main/resources/template/js/base/effect-clip.min.js
src/main/resources/template/js/base/effect-drop.min.js
src/main/resources/template/js/base/effect-explode.min.js
src/main/resources/template/js/base/effect-fade.min.js
src/main/resources/template/js/base/effect-fold.min.js
src/main/resources/template/js/base/effect-highlight.min.js
src/main/resources/template/js/base/effect-puff.min.js
src/main/resources/template/js/base/effect-pulsate.min.js
src/main/resources/template/js/base/effect-scale.min.js
src/main/resources/template/js/base/effect-shake.min.js
src/main/resources/template/js/base/effect-size.min.js
src/main/resources/template/js/base/effect-slide.min.js
src/main/resources/template/js/base/effect-transfer.min.js
src/main/resources/template/js/base/menu.min.js
src/main/resources/template/js/base/mouse.min.js
src/main/resources/template/js/base/position.min.js
src/main/resources/template/js/base/progressbar.min.js
src/main/resources/template/js/base/resizable.min.js
src/main/resources/template/js/base/selectable.min.js
src/main/resources/template/js/base/selectmenu.min.js
src/main/resources/template/js/base/slider.min.js
src/main/resources/template/js/base/sortable.min.js
src/main/resources/template/js/base/spinner.min.js
src/main/resources/template/js/base/tabs.min.js
src/main/resources/template/js/base/tooltip.min.js
src/main/resources/template/js/base/widget.min.js

The following steps could be taken

If wanted, i could make a pull request for it.

jogep commented 8 years ago

I think it his historic. In previous versions before 4.0.0 the was added all by hand just copied from the origin source. But some libraries does not provide a minified version so I build the automatic minifying of sources.

sdutry commented 8 years ago

@jogep Do you want me to create the pull request?

jogep commented 8 years ago

@sdutry PR is always welcome. ;-)