search

strvcom / ios-chat-component

Chat modular library
MIT License
1 stars 1 forks source link

Add stateful controller and empty conversation detail #51

Closed danpecher closed 4 years ago

danpecher commented 4 years ago

While adding empty state screen to conversation detail I tried to refactor controller states and created StatefulViewController. It unifies how the state of view controller is presented and allows for more states, for example an error.

schwarja commented 4 years ago

Btw, I like the view controller states 🙂

schwarja commented 4 years ago

@danpecher I just found out it is necessary to have networking_pods for ChatApp target in Podfile (you deleted it in the last PR). Right now Firebase resources are not linked to ChatApp bundle and the default Firebase authentication view controller can't be loaded

danpecher commented 4 years ago

@schwarja Really? Having them included twice causes a crash though - at least I think it does 😄

schwarja commented 4 years ago

@danpecher It was there before and I have it there now and it works like hell 🙂 It is not included twice it is included just once to different targets