search

strvcom / ios-chat-component

Chat modular library
MIT License
1 stars 1 forks source link

Resolve threading #55

Closed cejanen closed 4 years ago

cejanen commented 4 years ago

I added dedicated queues for both chatCore & networkingFirestore.

I used queues at few places when I evaluated its usefull

cejanen commented 4 years ago

@schwarja I walked through the code one more time and pushing new updates... similar approach I used also at networking

cejanen commented 4 years ago

@schwarja I update chate core & also merged with transaction PR now the rules I followed are: for place where task manager fits I used that in internal parts of callback I used queue directly at place when we return identifiers I used precondition at first place, else are included in bg tasks

I havent used dedicated queue at networking in transaction callbacks bc all logic is there and local variables of networking class is not used also no need to use task manager in networkfirestore just for call of bg thread

cejanen commented 4 years ago

@schwarja Im sure about three open places with precondition... we should crash immediately before other tasks in queue we run (bc we return at other thread)

cejanen commented 4 years ago

@schwarja Also merged with dev