pushd with no popd in build-jedi-cache.sh

strycore / fakegir

fakegir: Bring autocompletion to your PyGObject code

GNU General Public License v3.0

89 stars 16 forks source link

pushd with no popd in build-jedi-cache.sh #17

Closed realh closed 7 years ago

realh commented 7 years ago

I noticed build-jedi-cache.sh was printing $JEDI_PATH multiple times in a row and found that it has the line pushd $JEDI_PATH in a loop with no corresponding popd. I'm not sure whether it needs that pushd at all, so I just added popd before the loop's done and it seems to be working fine minus the extra 'noise'.

strycore commented 7 years ago

Thanks, I added that popd (and also made the output silent). I'm not sure that pushd is needed as well, @kassick is it here for a reason?

kassick commented 7 years ago

@strycore I can't see any good reason for the pushd -- I probably was sleepy when I did that, or paranoid that cwd would be different from the script's path or something

strycore commented 7 years ago

Ok, I'll remove it then :)