search

stryder-dev / flutter_platform_widgets

Target the specific design of Material for Android and Cupertino for iOS widgets through a common set of Platform aware widgets
MIT License
1.59k stars 174 forks source link

Bug: `iosUsesMaterialWidgets` and `legacyIosUsesMaterialWidgets` isn't used in `PlatformAlertDialog` #378

Closed josxha closed 1 year ago

josxha commented 1 year ago

The iosUsesMaterialWidgets and legacyIosUsesMaterialWidgets attributes are currently used for CupertinoScaffold and CupertinoTabScaffold, but have no effect on PlatformAlertDialog.

Since PlatformAlertDialog can also include material widgets, this functionality should be added here as well.

Example code:

await showPlatformDialog(context: context, builder: (context) {
  PlatformAlertDialog(
    content: ListTile(
      title: Text("This doesn't work on iOS because a Material widget is missing."),
    ),
  );
});
josxha commented 1 year ago

I created pull request https://github.com/stryder-dev/flutter_platform_widgets/pull/379 that fixes this issue.

aqwert commented 1 year ago

Version 2.2.6 is published