Closed korthout closed 7 years ago
Nice find! I'll test it tomorrow and let you know
Yo, it works. Fyi :+1:
Odd. Mine is still white. Are you running the Creators Update?
Interesting. I've was just in the opportunity to try it as well on a Windows machine.
In my powershell it didn't work either. I don't know anything about the Creators Update, but I found the following versioning information (perhaps it is the same):
> echo $PSVersionTable.PSVersion
Major Minor Build Revision
----- ----- ----- --------
4 0 -1 -1
@nicojs does yours also work without this PR (so using master)?
Lastly, I'd like to mention it does work properly in cmder
, however it already did so before this PR anyways.
Are you running the Creators Update?
How do i find out? This is what is shown in "About your PC"
PS > echo $PSVersionTable.PSVersion
Major Minor Build Revision
----- ----- ----- --------
5 1 14393 1198
So it does seem to work for Major version 5. @simondel can you confirm this?
1607 is the Anniversary Update, 1703 is the creators update. My ps version is:
Major Minor Build Revision
----- ----- ----- --------
5 1 15063 296
Chalk v1.1.3 is installed by default and does not fix the issue so I'll close this PR
This tries to fix #19.
The problem is a more general issue with Powershell's ability to deal with ANSI Codes. We use
chalk
to display colours and luckily they've been working on this problem too (see this and this).I hope that updating
chalk
to a newer version (1.1.1 -> 1.1.3) will solve the problem, but I have no way of testing it. @simondel Can you please verify whether this solves the problem?