search

stryker-mutator / stryker-js

Mutation testing for JavaScript and friends
https://stryker-mutator.io
Apache License 2.0
2.59k stars 251 forks source link

More control over context where mutations should apply #4141

Open rolandjohann opened 1 year ago

rolandjohann commented 1 year ago

Context After introducing mutation tests at the backend with PIT we now move on to the frontend and are doing some PoCs on a small react TypeScript code base. At the component unit tests we discovered that some styling relevant JSX attributes will be mutated, which we don't care at the unit tests and affect the mutation score negatively. The comments to disable mutations for the next line are not working at JSX - even if, the component implementation would be polluted with comments to ignore certain things.

Questions

Our current approach would be to don't mutate *.{jsx,tsx} to prevent JSX attribute literas from being mutated. We are happy to get feedback, also from others how they incorporate mutation testing at a react implementation an their experience.

Thanks in advance, and a big thanks to the Stryker OSS community for this tool 👌.

Stryker environment

❯ yarn list | grep stryker ```bash ├─ @stryker-mutator/api@6.4.2 ├─ @stryker-mutator/core@6.4.2 │ ├─ @stryker-mutator/api@6.4.2 │ ├─ @stryker-mutator/instrumenter@6.4.2 │ ├─ @stryker-mutator/util@6.4.2 ├─ @stryker-mutator/instrumenter@6.4.2 │ ├─ @stryker-mutator/api@6.4.2 │ ├─ @stryker-mutator/util@6.4.2 ├─ @stryker-mutator/jest-runner@6.4.2 │ ├─ @stryker-mutator/api@6.4.2 │ ├─ @stryker-mutator/util@6.4.2 ├─ @stryker-mutator/typescript-checker@6.4.2 │ ├─ @stryker-mutator/api@6.4.2 │ ├─ @stryker-mutator/util@6.4.2 ├─ @stryker-mutator/util@6.4.2 ```
❯ yarn list | grep jest ``` ├─ @happy-dom/jest-environment@9.9.2 │ ├─ @jest/environment@^29.4.0 │ ├─ @jest/fake-timers@^29.4.0 │ ├─ @jest/types@^29.4.0 │ ├─ jest-mock@^29.4.0 │ └─ jest-util@^29.4.0 ├─ @jest/console@29.5.0 │ ├─ @jest/types@^29.5.0 │ ├─ jest-message-util@^29.5.0 │ ├─ jest-util@^29.5.0 ├─ @jest/core@29.5.0 │ ├─ @jest/console@^29.5.0 │ ├─ @jest/reporters@^29.5.0 │ ├─ @jest/test-result@^29.5.0 │ ├─ @jest/transform@^29.5.0 │ ├─ @jest/types@^29.5.0 │ ├─ jest-changed-files@^29.5.0 │ ├─ jest-config@^29.5.0 │ ├─ jest-haste-map@^29.5.0 │ ├─ jest-message-util@^29.5.0 │ ├─ jest-regex-util@^29.4.3 │ ├─ jest-resolve-dependencies@^29.5.0 │ ├─ jest-resolve@^29.5.0 │ ├─ jest-runner@^29.5.0 │ ├─ jest-runtime@^29.5.0 │ ├─ jest-snapshot@^29.5.0 │ ├─ jest-util@^29.5.0 │ ├─ jest-validate@^29.5.0 │ ├─ jest-watcher@^29.5.0 ├─ @jest/environment@29.5.0 │ ├─ @jest/fake-timers@^29.5.0 │ ├─ @jest/types@^29.5.0 │ └─ jest-mock@^29.5.0 ├─ @jest/expect-utils@29.5.0 │ └─ jest-get-type@^29.4.3 ├─ @jest/expect@29.5.0 │ └─ jest-snapshot@^29.5.0 ├─ @jest/fake-timers@29.5.0 │ ├─ @jest/types@^29.5.0 │ ├─ jest-message-util@^29.5.0 │ ├─ jest-mock@^29.5.0 │ └─ jest-util@^29.5.0 ├─ @jest/globals@29.5.0 │ ├─ @jest/environment@^29.5.0 │ ├─ @jest/expect@^29.5.0 │ ├─ @jest/types@^29.5.0 │ └─ jest-mock@^29.5.0 ├─ @jest/reporters@29.5.0 │ ├─ @jest/console@^29.5.0 │ ├─ @jest/test-result@^29.5.0 │ ├─ @jest/transform@^29.5.0 │ ├─ @jest/types@^29.5.0 │ ├─ jest-message-util@^29.5.0 │ ├─ jest-util@^29.5.0 │ ├─ jest-worker@^29.5.0 ├─ @jest/schemas@29.4.3 ├─ @jest/source-map@29.4.3 ├─ @jest/test-result@29.5.0 │ ├─ @jest/console@^29.5.0 │ ├─ @jest/types@^29.5.0 ├─ @jest/test-sequencer@29.5.0 │ ├─ @jest/test-result@^29.5.0 │ ├─ jest-haste-map@^29.5.0 ├─ @jest/transform@29.5.0 │ ├─ @jest/types@^29.5.0 │ ├─ jest-haste-map@^29.5.0 │ ├─ jest-regex-util@^29.4.3 │ ├─ jest-util@^29.5.0 ├─ @jest/types@29.5.0 │ ├─ @jest/schemas@^29.4.3 │ ├─ eslint-plugin-jest-dom@^4.0.2 │ ├─ eslint-plugin-jest@^26.9.0 │ ├─ @jest/transform@^29.3.1 │ ├─ @jest/types@27.5.1 │ ├─ jest-mock@^27.0.6 │ ├─ jest-mock@27.5.1 │ │ ├─ @jest/types@^27.5.1 ├─ @stryker-mutator/jest-runner@6.4.2 ├─ @testing-library/jest-dom@5.16.5 │ ├─ @types/testing-library__jest-dom@^5.9.1 ├─ @types/jest@29.5.1 ├─ @types/testing-library__jest-dom@5.14.5 │ └─ @types/jest@* ├─ babel-jest@29.5.0 │ ├─ @jest/transform@^29.5.0 │ ├─ babel-preset-jest@^29.5.0 ├─ babel-plugin-jest-hoist@29.5.0 ├─ babel-preset-jest@29.5.0 │ ├─ babel-plugin-jest-hoist@^29.5.0 ├─ eslint-plugin-jest-dom@4.0.3 ├─ eslint-plugin-jest@26.9.0 │ ├─ @jest/expect-utils@^29.5.0 │ ├─ jest-get-type@^29.4.3 │ ├─ jest-matcher-utils@^29.5.0 │ ├─ jest-message-util@^29.5.0 │ └─ jest-util@^29.5.0 ├─ jest-changed-files@29.5.0 ├─ jest-circus@29.5.0 │ ├─ @jest/environment@^29.5.0 │ ├─ @jest/expect@^29.5.0 │ ├─ @jest/test-result@^29.5.0 │ ├─ @jest/types@^29.5.0 │ ├─ jest-each@^29.5.0 │ ├─ jest-matcher-utils@^29.5.0 │ ├─ jest-message-util@^29.5.0 │ ├─ jest-runtime@^29.5.0 │ ├─ jest-snapshot@^29.5.0 │ ├─ jest-util@^29.5.0 ├─ jest-cli@29.5.0 │ ├─ @jest/core@^29.5.0 │ ├─ @jest/test-result@^29.5.0 │ ├─ @jest/types@^29.5.0 │ ├─ jest-config@^29.5.0 │ ├─ jest-util@^29.5.0 │ ├─ jest-validate@^29.5.0 ├─ jest-config@29.5.0 │ ├─ @jest/test-sequencer@^29.5.0 │ ├─ @jest/types@^29.5.0 │ ├─ babel-jest@^29.5.0 │ ├─ jest-circus@^29.5.0 │ ├─ jest-environment-node@^29.5.0 │ ├─ jest-get-type@^29.4.3 │ ├─ jest-regex-util@^29.4.3 │ ├─ jest-resolve@^29.5.0 │ ├─ jest-runner@^29.5.0 │ ├─ jest-util@^29.5.0 │ ├─ jest-validate@^29.5.0 ├─ jest-diff@29.5.0 │ ├─ jest-get-type@^29.4.3 ├─ jest-docblock@29.4.3 ├─ jest-each@29.5.0 │ ├─ @jest/types@^29.5.0 │ ├─ jest-get-type@^29.4.3 │ ├─ jest-util@^29.5.0 ├─ jest-environment-jsdom@29.5.0 │ ├─ @jest/environment@^29.5.0 │ ├─ @jest/fake-timers@^29.5.0 │ ├─ @jest/types@^29.5.0 │ ├─ jest-mock@^29.5.0 │ ├─ jest-util@^29.5.0 ├─ jest-environment-node@29.5.0 │ ├─ @jest/environment@^29.5.0 │ ├─ @jest/fake-timers@^29.5.0 │ ├─ @jest/types@^29.5.0 │ ├─ jest-mock@^29.5.0 │ └─ jest-util@^29.5.0 ├─ jest-get-type@29.4.3 ├─ jest-haste-map@29.5.0 │ ├─ @jest/types@^29.5.0 │ ├─ jest-regex-util@^29.4.3 │ ├─ jest-util@^29.5.0 │ ├─ jest-worker@^29.5.0 ├─ jest-leak-detector@29.5.0 │ ├─ jest-get-type@^29.4.3 ├─ jest-matcher-utils@29.5.0 │ ├─ jest-diff@^29.5.0 │ ├─ jest-get-type@^29.4.3 ├─ jest-message-util@29.5.0 │ ├─ @jest/types@^29.5.0 ├─ jest-mock@29.5.0 │ ├─ @jest/types@^29.5.0 │ └─ jest-util@^29.5.0 ├─ jest-pnp-resolver@1.2.3 ├─ jest-regex-util@29.4.3 ├─ jest-resolve-dependencies@29.5.0 │ ├─ jest-regex-util@^29.4.3 │ └─ jest-snapshot@^29.5.0 ├─ jest-resolve@29.5.0 │ ├─ jest-haste-map@^29.5.0 │ ├─ jest-pnp-resolver@^1.2.2 │ ├─ jest-util@^29.5.0 │ ├─ jest-validate@^29.5.0 ├─ jest-runner@29.5.0 │ ├─ @jest/console@^29.5.0 │ ├─ @jest/environment@^29.5.0 │ ├─ @jest/test-result@^29.5.0 │ ├─ @jest/transform@^29.5.0 │ ├─ @jest/types@^29.5.0 │ ├─ jest-docblock@^29.4.3 │ ├─ jest-environment-node@^29.5.0 │ ├─ jest-haste-map@^29.5.0 │ ├─ jest-leak-detector@^29.5.0 │ ├─ jest-message-util@^29.5.0 │ ├─ jest-resolve@^29.5.0 │ ├─ jest-runtime@^29.5.0 │ ├─ jest-util@^29.5.0 │ ├─ jest-watcher@^29.5.0 │ ├─ jest-worker@^29.5.0 ├─ jest-runtime@29.5.0 │ ├─ @jest/environment@^29.5.0 │ ├─ @jest/fake-timers@^29.5.0 │ ├─ @jest/globals@^29.5.0 │ ├─ @jest/source-map@^29.4.3 │ ├─ @jest/test-result@^29.5.0 │ ├─ @jest/transform@^29.5.0 │ ├─ @jest/types@^29.5.0 │ ├─ jest-haste-map@^29.5.0 │ ├─ jest-message-util@^29.5.0 │ ├─ jest-mock@^29.5.0 │ ├─ jest-regex-util@^29.4.3 │ ├─ jest-resolve@^29.5.0 │ ├─ jest-snapshot@^29.5.0 │ ├─ jest-util@^29.5.0 ├─ jest-snapshot@29.5.0 │ ├─ @jest/expect-utils@^29.5.0 │ ├─ @jest/transform@^29.5.0 │ ├─ @jest/types@^29.5.0 │ ├─ jest-diff@^29.5.0 │ ├─ jest-get-type@^29.4.3 │ ├─ jest-matcher-utils@^29.5.0 │ ├─ jest-message-util@^29.5.0 │ ├─ jest-util@^29.5.0 ├─ jest-util@29.5.0 │ ├─ @jest/types@^29.5.0 ├─ jest-validate@29.5.0 │ ├─ @jest/types@^29.5.0 │ ├─ jest-get-type@^29.4.3 ├─ jest-watcher@29.5.0 │ ├─ @jest/test-result@^29.5.0 │ ├─ @jest/types@^29.5.0 │ ├─ jest-util@^29.5.0 ├─ jest-worker@29.5.0 │ ├─ jest-util@^29.5.0 ├─ jest@29.5.0 │ ├─ @jest/core@^29.5.0 │ ├─ @jest/types@^29.5.0 │ └─ jest-cli@^29.5.0 │ ├─ @jest/schemas@^29.4.3 ```
nicojs commented 1 year ago

is it possible to disable mutations with comments at JSX?

Yes, you can use // Stryker disable comments. See https://stryker-mutator.io/docs/stryker-js/disable-mutants/#using-a--stryker-disable-comment for details.

(even better) is it possible to define rules at which context mutations should not apply?

3229 is probably what you want. Please upvote that one.

Thanks in advance, and a big thanks to the Stryker OSS community for this tool 👌.

You're welcome :)