Closed dupdob closed 4 months ago
@JAKeijzer96 : many thanks for the amazing editorial work here!!. Btw, this document applies to the version in this PR. My initial objective was to write this doc, but I realized the design needed rework when writing it. Simple rule is: if it is hard to document, it can not stay as is.
@richardwerkman : your feedback is most welcomed. And thanks for the taking the time to read all this. This PR is probably no picnic to review
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
91.4% Coverage on New Code
0.0% Duplication on New Code
Redesigned MutationStore and MutationContext classes to a simpler and more consistent design.
Redesigned function/method/accessor/lambda orchestrator via a common parent class. Removed all
xxxExpressionToBodyEngine
classes.Fixed following (non reported) bugs: 1) LocalFunction orchestrator may generate invalid local functions by adding erroneous
return
to void method (can be seen in the old unit test 🤦 ) 2) Improvedreturn default
injection policy. Those are injected only when:void
(includingasync Task
) return typereturn
present in the blockreturn
statementyield
modifiers present) 3) Add proper support for async local functions (not supported before) 4) More consistent handling across methods/functions/accessors... 5) provide support document explaining the purpose of each class used during CSharpOrchestration.Many classes and lines of code have been removed, and hundreds of documentation lines have been added.
I must say I am quite happy with this one, borderline on proud. 😆
EDIT: obviously the associated documentation refers to this design and not the existing one