search

stryker-mutator / stryker-net

Mutation testing for .NET core and .NET framework!
https://stryker-mutator.io
Apache License 2.0
1.75k stars 176 forks source link

warning CS0618: VsTest Console Wrapper 'The async APIs don't work, use the sync API instead.' #2853

Closed rouke-broersma closed 4 months ago

rouke-broersma commented 4 months ago

Describe the bug warning CS0618: 'IVsTestConsoleWrapperAsync.RunTestsWithCustomTestHostAsync(IEnumerable, string?, TestPlatformOptions?, ITestRunEventsHandler, ITestHostLauncher)' is obsolete: 'The async APIs don't work, use the sync API instead.'

warning CS0618: 'IVsTestConsoleWrapperAsync.DiscoverTestsAsync(IEnumerable, string?, ITestDiscoveryEventsHandler)' is obsolete: 'The async APIs don't work, use the sync API instead.'

dupdob commented 4 months ago

PR #2845 fixes that properly: we need some form of async to recover from VsTest freezes

dupdob commented 4 months ago

note that this (obsolete) attribute has been added by an external contributor to the VsTest codebase and is not substantiated in any way 😄 Yep, I was too cursory on this one

rouke-broersma commented 4 months ago

nohwnd is not an external contributor, they work for microsoft on vstest. It was added here: https://github.com/microsoft/vstest/pull/4648 and substantiated here: https://github.com/microsoft/vstest/issues/4592

dupdob commented 4 months ago

thanks for the rectification. And indeed, the fact is that they async apis have little added value (except for somewhat better dealing with freezes)