fix: Conditional access mutations could lead to unrecoverable NullReferenceException in compilation

[dupdob]

Fix issues related to Conditional Access (and NullSuppression operator) Add recovery mechanism for when the compilation triggers null reference exception

Fix #2880

[richardwerkman]

I've tested this and it seems to work :)

But I'm still seeing some error logging:

[17:23:35 ERR] Some mutations failed to be inserted, they are dropped.
[17:23:35 ERR] Some mutations failed to be inserted, they are dropped.
[17:23:35 ERR] Some mutations failed to be inserted, they are dropped.
[17:24:53 ERR] VsTestRunner: Coverage collector error: Did not find type StrykerH7r178e2ZZDsDvd.MutantControl. This indicates Stryker failed to copy the mutated assembly for test..
[17:24:53 ERR] VsTestRunner: Coverage collector error: Did not find type StrykerH7r178e2ZZDsDvd.MutantControl. This indicates Stryker failed to copy the mutated assembly for test..

When was this added? And should we fix these in this PR? Or can we fix this later

[dupdob]

Thanks for reporting.

I've tested this and it seems to work :)

But I'm still seeing some error logging:

[17:23:35 ERR] Some mutations failed to be inserted, they are dropped.
[17:23:35 ERR] Some mutations failed to be inserted, they are dropped.
[17:23:35 ERR] Some mutations failed to be inserted, they are dropped.

This is not new, there was several way for mutations to be silently loss along the way. My last refactoring made the process more trustworthy. That being said, this should not be reported as an error. I fill fix that.

[17:24:53 ERR] VsTestRunner: Coverage collector error: Did not find type StrykerH7r178e2ZZDsDvd.MutantControl. This indicates Stryker failed to copy the mutated assembly for test..
[17:24:53 ERR] VsTestRunner: Coverage collector error: Did not find type StrykerH7r178e2ZZDsDvd.MutantControl. This indicates Stryker failed to copy the mutated assembly for test..

I think I added this in my refactor PR while analyzing some strange issues. At first I assumed there was a problem copying the mutated assembly, but it turned out to be that Stryker was running unrelated test

Will fix in this PR

[dupdob]

Continuing comment:

[17:24:53 ERR] VsTestRunner: Coverage collector error: Did not find type StrykerH7r178e2ZZDsDvd.MutantControl. This indicates Stryker failed to copy the mutated assembly for test..
[17:24:53 ERR] VsTestRunner: Coverage collector error: Did not find type StrykerH7r178e2ZZDsDvd.MutantControl. This indicates Stryker failed to copy the mutated assembly for test..

So these are triggered by the mutated assembly not being tested by any test. It can happen with solution mode due to the support for transitive testing. In Stryker's case, these are triggered by Stryker.RegexMutators. This messages could also be triggered by the mutated assembly failing to copy for some reason

==> I downgraded severity down to Debug and stressed the lack of testing as the probable cause

[dupdob]

@richardwerkman : it should be ok now, could please check it again and confirm on your side?

[sonarcloud[bot]]

Quality Gate failed

Failed conditions
51.8% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

[richardwerkman]

@dupdob thanks for the quick fix! Great work 👍

[dupdob]

your feedback is welcomed 😄