search

sts10 / radiation

A simple blog CMS for totallynuclear.club pages.
MIT License
16 stars 3 forks source link

Change Initial Script to Populate Bash/Zsh Profile #6

Open danielspector opened 9 years ago

danielspector commented 9 years ago

One of the improvement suggestions made was to help the installation by making it easier to get started. This will automatically append the radiation command to a user's bash or zsh profile. I figured it would be easier to maintain to use a bash script rather than a ruby file with system commands.

I also changed the README to reflect the new instructions.

Would love any input.

sts10 commented 9 years ago

Hey man, thanks for this!

Before I merge though-- what happens if a user runs this new install script twice? Obviously they only need to run it once given what's in there, but I'm trying to keep the process as fool-proof as possible.

Will their bash_profile now contain two radiation functions? What do you think about the current solution I put in where it greps for "function radiation"?:

has_function = open('../.bash_profile').grep(/function radiation/)
if has_function != []
    # etc.
danielspector commented 9 years ago

Hmm... It should probably check for a zsh profile as well as bash, other than that you're right the script is currently populating the profile with the function regardless of whether it exists or not. I'm going to look into fixing it and will update the request.

sts10 commented 9 years ago

That'd be awesome.