search

sts10 / radiation

A simple blog CMS for totallynuclear.club pages.
MIT License
16 stars 3 forks source link

Added a menuitem to allow people to update the timestamp on a post #9

Closed gunnarhafdal closed 9 years ago

gunnarhafdal commented 9 years ago

This is related to the drafts pull request (#8) because I basically thought to myself that a person might make a draft, work on it for a few days and then when it's time to publish it the timestamp is all wrong, and then she would have to go and edit the file name manually and no one should have to do that. So I copied the delete menu item and renamed it to "Update timestamp on a post" using the letter "u". When you have selected a post it makes you confirm your action and then it renames it with the current time.

Again, as with drafts, not sure if this fits the use case of how people are using Radiation, I made this just because it's Sunday and I have nothing better to do, and also I have been hit once where I made a post and then wrote it over the course of a day and had to delete and create a new file to have the right timestamp.

sts10 commented 9 years ago

Hello!

Thank you so much for these pull requests! I had definitely been toying with the idea of allowing drafts.

I'm excited to look over these changes when I get a minute, but it looks really good. It even looks like you followed some of my patterns, which is super nice of you. I'll hopefully get to them in the next few days-- accepting even this must code via a pull request is a bit new for me!

gunnarhafdal commented 9 years ago

Sounds great. I'm also pretty new to using pull requests on public projects which I forked. I've used it a lot at work though for feature branches. Works pretty well.

Glad to hear that what I wrote seems to fit your pattern, I'm not a Ruby developer so that was pure coincident. I did copy and paste a lot and modify from there on so that might be why.