search

stsievert / salmon

A tool to collect triplet queries
https://docs.stsievert.com/salmon/
BSD 3-Clause "New" or "Revised" License
9 stars 2 forks source link

BUG: error on zip file upload #101

Closed stsievert closed 3 years ago

stsievert commented 3 years ago

What does this PR implement? A simple typo in salmon/frontend/utilis.py that prevented an experimentalist from uploading a ZIP file. It also makes some other changes:

  1. MAINT: Cleans examples/datasets (remove unused code, better organize)
  2. MAINT/TST: Adds random state back in – but only for initialization (and test it too).
  3. TST: fix zip file tests so they run with pytest (→ remove xfail)
  4. TST: test uploads of each example in examples/.

If I had tested (4) to start with, I wouldn't have needed to develop this PR.

Reference issues/PRs This PR closes #99.