stsievert / salmon

A tool to collect triplet queries
https://docs.stsievert.com/salmon/
BSD 3-Clause "New" or "Revised" License
9 stars 2 forks source link

API: implement SRR and various maintenance/improvement tasks. #118

Closed stsievert closed 3 years ago

stsievert commented 3 years ago

What does this PR implement? It allows the following:

Backwards incompatible changes

Reference issues/PRs This closes #114 and #117.

stsievert commented 3 years ago

@crcox does this resolve your issue? I think this is similar to the external ID/ext_id you mentioned in #117.

crcox commented 3 years ago

Yes, that will do the trick. Clarification on validation queries: is it something like

samplers: {
    Validation: {},
    queries: [[0, 1, 2], [3, 4, 5]]
}

or

samplers: {
    Validation: {
        queries: [[0, 1, 2], [3, 4, 5]]
    }
}

?

stsievert commented 3 years ago

basic.yaml shows an example of how to specify the indices. Here's a snippet:

samplers:
  ARR: {}
  Random: {}
  Validation:
    queries: [[0, 1, 2], [3, 4, 5], [6, 7, 8]]

(updated to reflect sampler renaming)

crcox commented 3 years ago

Perfect, thanks!

stsievert commented 3 years ago

Most tests are passing locally, all except 3. That's a non-issue; I'm testing that errors get logged, and can't restart docker in the middle of the tests. If I could, those tests would pass.