search

stsievert / salmon

A tool to collect triplet queries
https://docs.stsievert.com/salmon/
BSD 3-Clause "New" or "Revised" License
9 stars 2 forks source link

Use HTTPS #119

Closed stsievert closed 3 years ago

stsievert commented 3 years ago

As reported by @crcox, Qualtrics enforces the HTTPS protocol. Currently, Salmon uses HTTP.

It'd be convenient if Salmon would allow HTTPS so it could be used with Qualtrics.

stsievert commented 3 years ago

HTTPS certificates can be created with mkcert (https://github.com/FiloSottile/mkcert), so it shouldn't be too bad.

One potential complication: Salmon uses HTTP internally to communicate between Docker containers. This would be resolved by the use of a TLS termination proxy, as expressed in the these FastAPI docs:

It is a common practice to have one program/HTTP server running on the server (the machine, host, etc.) and managing all the HTTPS parts : sending the decrypted HTTP requests to the actual HTTP application running in the same server (the FastAPI application, in this case), take the HTTP response from the application, encrypt it using the appropriate certificate and sending it back to the client using HTTPS. This server is often called a TLS Termination Proxy.