MAINT: only use Skorch for initialization

stsievert / salmon

A tool to collect triplet queries

https://docs.stsievert.com/salmon/

BSD 3-Clause "New" or "Revised" License

9 stars 2 forks source link

MAINT: only use Skorch for initialization #90

Closed stsievert closed 3 years ago

stsievert commented 3 years ago

What does this PR implement? It removes spaghetti code around Skorch. In v0.4.5 and v0.4.4, I only use Skorch for initialization, but _embed.Embedding still inherits from Skorch's NeuralNet. This PR removes that.

Reference issues/PRs