search

stsquad / emacs_chrome

A Chromium/Firefox "clone" of It's All Text for spawning an editor to edit text areas in browsers. Based on David Hilley's original Chromium extension.
https://chrome.google.com/extensions/detail/ljobjlafonikaiipfkggjbhkghgicgoh
GNU General Public License v3.0
512 stars 91 forks source link

Fix issue that `edit-server-make-frame` creates GUI window frame when… #141

Closed twlz0ne closed 4 years ago

twlz0ne commented 6 years ago

… running emacs with -nw

edit-server-make-frame-creates-gui-window-frame-when-running-emacs-with-nw
stsquad commented 6 years ago

We need a better solution that works for the terminal case and doesn't break the window mode case. See #132/#133 and #103 which originally did this.

stsquad commented 6 years ago

By the way what does the log show if you C-u M-x edit-server-start?

twlz0ne commented 6 years ago

Nothing at all, here are my steps:

  1. M-: (kill-buffer "*Messages*")
  2. C-u M-x edit-server-start

  3. Switch to *Messages*:

    t
stsquad commented 6 years ago

@twlz0ne did you attempt to edit something?

stsquad commented 4 years ago

House keeping, this PR is obsolete as you can control things by defining frame parameters.