search

stsquad / emacs_chrome

A Chromium/Firefox "clone" of It's All Text for spawning an editor to edit text areas in browsers. Based on David Hilley's original Chromium extension.
https://chrome.google.com/extensions/detail/ljobjlafonikaiipfkggjbhkghgicgoh
GNU General Public License v3.0
512 stars 91 forks source link

Use `make-frame` #155

Closed elibarzilay closed 5 years ago

elibarzilay commented 5 years ago

There is no reason that I see to use make-frame-on-display.

Even if there is, it shouldn't ignore edit-server-new-frame-alist.

stsquad commented 5 years ago

I'd like to apply this but I'd like to understand the bug/feature I'm seeing. I start my emacs in --daemon mode however if there are no visible X frames when I invoke the edit server Emacs creates an invisible frame. If I pop up an emacsclient session I can visit the buffer and complete the editing. I'm not sure if this has something to do with the frame I see in frame-list:

$ emacsclient -e "(frame-list)"
(#<frame F1 0xa857b0>)

This isn't attached to any terminal but seems to always exist for --daemon sessions.

stsquad commented 5 years ago

If I have a terminal session open then the new frame does get opened on that terminal.

stsquad commented 5 years ago

Ahh I think I just need to better document the use of (window . FOO) in the customisation.

stsquad commented 5 years ago

@elibarzilay thanks