search

ststeiger / PdfSharpCore

Port of the PdfSharp library to .NET Core - largely removed GDI+ (only missing GetFontData - which can be replaced with freetype2)
Other
1.07k stars 239 forks source link

Implement missing XForm.Finish() method #310

Closed ascott18 closed 1 year ago

ascott18 commented 1 year ago

This omission seems accidental (it was entirely wrapped in an #if gdi in the original version, but only two lines of it were GDI-only).

The absence of an implementation here was breaking #243. Taken directly from the upstream implementation https://github.com/empira/PDFsharp/blob/3205bd933b464d150c0f42e8bcdff3314b6c6164/src/PdfSharp/Drawing/XForm.cs#L231-L262.

ststeiger commented 1 year ago

@ascott18: Could you please replace all occurences of Debug.Assert in your code with throwing an exception ? Debug.Assert is not good - it causes the entire application to exit, which is particularly bad in a web-application.

ascott18 commented 1 year ago

@ststeiger Done,

ststeiger commented 1 year ago

@ascott18: Sorry for the delay. Merged.