ststeiger / PdfSharpCore

Port of the PdfSharp library to .NET Core - largely removed GDI+ (only missing GetFontData - which can be replaced with freetype2)
Other
1.04k stars 231 forks source link

Translation of image base for rotation is a huge breaking change! #407

Open Syntaxrabbit opened 8 months ago

Syntaxrabbit commented 8 months ago

This commit should not have been released to Nuget as a minor release: https://github.com/ststeiger/PdfSharpCore/commit/3e025295800b8db9322677d68df9cf89db2adeac

Including external PDFs and changing rotation automatically according to page width and height now leads to tons of resulting images, where 75% of the included page is outside its target box or even outside of its page. Whe have to change lots of code for customer's modules for correcting this.

Please announce future breaking changes accordingly and even better, increase the second major version number instead of the minor version. Thank you in advance.