search

ststeiger / PdfSharpCore

Port of the PdfSharp library to .NET Core - largely removed GDI+ (only missing GetFontData - which can be replaced with freetype2)
Other
1.08k stars 237 forks source link

Enabled Multitargeting #409

Closed TonyValenti closed 9 months ago

TonyValenti commented 1 year ago

Hi @ststeiger - I have enhanced this commit and am hoping you will merge this in.

This commit basically does the following:

IF the DotNet version is 6.0-8.0 THEN
   Use the latest versions of ImageSharp
ELSE
  Use the older versions of ImageSharp
ENDIF

It also splits ImageSharpImageSource.cs into a NET6 portion and a NETSTANDARD portion, each of which are optionally included based on the target framework.

This will allow the library to support current and historical .NET frameworks as well has current and historical ImageSharp versions.

steeltomato commented 1 year ago

Something seems off with the changes. With the assembly targeting, the TargetFrameworks scope reductions in some of the packages shouldn't be needed, correct? Also, I suspect you don't want to commit versions into the .csproj.

KlaskSkovby commented 10 months ago

No we don't want the newer version of ImageSharp as they have changed the license for newer releases of the package