Enable compatibility with old and new image sharp versions.

ststeiger / PdfSharpCore

Port of the PdfSharp library to .NET Core - largely removed GDI+ (only missing GetFontData - which can be replaced with freetype2)

Other

1.04k stars 231 forks source link

Enable compatibility with old and new image sharp versions. #427

Open TonyValenti opened 4 months ago

TonyValenti commented 4 months ago

(Only NET60 and above use the new ImageSharp.) Rebase and Cleanup commits.

TonyValenti commented 4 months ago

Hi @ststeiger Would you please give this code a review? I've cleaned things up quite a bit since the original PR and rebased on your latest commit. The changes are:

Based on your latest commit
Quite minimal
Only use new ImageSharp versions for recent .NET versions

I really expect it would only take a few minutes of your time to review and compare.

subahan-kothawal commented 1 month ago

@ststeiger can you please review these changes and merge. we indeed require these update.

TonyValenti commented 3 days ago

Hi @ststeiger ! Welcome back! I just resolved the conflicts so you can merge this.