search

stt-datacore / bot

6 stars 6 forks source link

Best Voyage command not returning results as desired #19

Open Darxide23 opened 3 years ago

Darxide23 commented 3 years ago

For example, searching -d best voyage dip eng will return this list:

Adira Tal Interfaced La Forge D'Nesh Bridge Officer Number One Ishan Chaye Sisko Stranded Quark Queen Po Sergey and Helena Rozhenko Facer Rios Captain Thadiun Okona

While this may perhaps be the "best" strictly DIP/ENG crew out there, it completely neglects the third skill. Nobody in their right mind would ever send D'Nesh or the Rozhenkos on a voyage unless they simply had no other choice. Their lack of a third skill makes them far worse than using someone much, much further down the list.

But more compelling than that, I think when searching for best voyage options the total skill points contributed should be how the results are returned so that there is parity between this list and how they are represented on the Datacore.app website where the Rozhenkos are listed as the 15th best ENG/DIP.

ineffyble commented 3 years ago

@Darxide23 So this is a difference between the "pairs" that the bot shows (which are also what Captain Idol's DataCore Analysis Sheet uses), and the "combos" the website shows, which incorporate the third skill at 1/4 value.

Idol and I have been discussing the relative merits of both, the plan is to expose both pairs and combos in all places eventually. There's pros and cons to both approaches.

Darxide23 commented 3 years ago

That's good news. The option to view them either way you'd like is always great. As for now, I'm unsure how to even find a list of voyage pairs by "combos" as you call them so having the ability to do so in the bot is what I'm really hoping for.