stt-datacore / bot

6 stars 6 forks source link

crewneed command giving inaccurate info #33

Open ineffyble opened 3 years ago

ineffyble commented 3 years ago
wathou6 — 07/05/2021
crewneed command seems like there's a bug with the breakdown portion. It's not showing and factoring in the 3* and 4* items needed for the next time

ineffyble — 07/05/2021
Are you sure it's not just hiding items because you already own them?
It only shows items you don't have enough of

wathou6 — Today at 08:11
I had only 0 of the required items (i.e. 4* database, 4* casing, 3* polyalloy, & 3* microconnector ) and those items can’t be constructed either

ineffyble — Today at 08:29
Interesting. Was your profile on datacore up to date?

wathou6 — Today at 09:45
Yes it was up to date and trying the command again doesn't show any difference with the same data

wathou6 — Today at 10:00
also I'm not sure why it says I need power cells when they're not part of the recipe needed for Trill Burnham's equipment at level 93

ineffyble — Today at 11:01
Can  you have a look at https://datacore.app/ for trill burnham
And see if all the items and recipes show right for her
Want to find out if the issue is with the source data or the command

wathou6 — Today at 11:19
i looked the recipes and it seems like the command is pulling the highest level item instead of the missing item
my Trill Burnham is at level 99 but is only missing the level 93 equipment

ineffyble — Today at 12:16
Huh, that's odd. I'll create an issue ticket and hopefully someone can take a peek soon.
ineffyble commented 2 years ago

The fault lies here: https://github.com/stt-datacore/bot/blob/adabf70bdd6301c494d392b95f0ac39cbd631b94/src/utils/equipment.ts#L86

and applies the opposite way too, in that it can assume a crew needs items they already have, if the required level for that item is equal to the crew's level