search

sttz / expresso

expresso is a command line interface to control the ExpressVPN app
MIT License
63 stars 11 forks source link

Windows support #10

Closed lord-ne closed 3 years ago

lord-ne commented 3 years ago

Added Windows support by adding platform checks for manifestBasePaths and the name of the manifest file.

sttz commented 3 years ago

Thanks!

If you have time, can you try the new Windows build? https://github.com/sttz/expresso/releases/download/1.2.0/expresso-1.2.0-win64.zip

lord-ne commented 3 years ago

It's failing with "Timed out waiting for the result." However, for some reason my exe that was working fine yesterday is now also failing with the same error. Interestingly, using dotnet run -r win-x64 -f net6.0 on the source works correctly. Once I get the old exe working again, I'll check if the new one works.

lord-ne commented 3 years ago

It looks like it is genuinely timing out; it occasionally works, but not reliably. ExpressVPN is being slow to respond on Windows for some reason. Multiplying ResponseTimeout and the default timeout for WaitForConnection by 10 (in ExpressVPNClient.cs, lines 145 and 240) fixes the issue. I think waiting 5 to 10 seconds to timeout is pretty reasonable, since it's treated as an unrecoverable error anyway.