search

stuartlangridge / gnome-shell-clock-override

Override the Gnome Shell clock with a new time format or text of your choice. Works with new versions of Shell such as 3.18
MIT License
89 stars 33 forks source link

Clock face rounding and vulgar fraction rounding do not coincide #32

Open brandl-muc opened 5 years ago

brandl-muc commented 5 years ago

For the minute range :00 to :29 the Unicode symbols CLOCK FACE XXX OCLOCK is used (e.g. 🕒), for the range :30 to :59 CLOCK FACE XXX-THIRTY is used (e.g. 🕣). This means that the minutes are truncated (rounded down) to half hours. The vulgar fractions on the other side are rounded to the nearest quarter hour.

This is unintuitive behavior and leads to results as "🕔 17 1/2" for times such as 17:28. Note that the vulgar fraction already shows "half past" but the Unicode clock face still represents "whole" hour.

I think the OCLOCK symbol should be used for the range :45 to :14 and the THIRTY symbol for the range :15 to :44.

brandl-muc commented 5 years ago

Consequence of writing tests and getting unexpected results...

da2x commented 5 years ago

Agreed. Pull requests are welcome.

brandl-muc commented 5 years ago

Will do, but tests first.