Open eitsupi opened 1 year ago
chown
ing mount folders in lifecycle scripts do work better, I recently tested this on some of my features (e.g. aws-cli-persistence). There are two main benefits:
.zshrc
or other config filesThe lifecycle script change will also affect azure-cli-persistence
. @stuartleeks what do you think about these changes? I might make a PR when i have some free time
FYI, I have created a Feature using lifecycle scripts to save R Terminal history https://github.com/rocker-org/devcontainer-features/tree/main/src/r-history I've been using this for a while now and it seems to be working well, so I think we can do the same here.
Oh great! I really like your method copying the lifecycle script, it's a lot cleaner than the one I found from devcontainer/features
. I'll probably adopt this style in my features as well 😄
I suspect that what is currently done in install.sh could be transferred to scripts that is executed by
postCreateCommand
etc.