Updated readme to include an example

stuartpb / dokku-bind-port

Dokku plugin for binding app container ports to host interfaces

MIT License

16 stars 3 forks source link

Closed kylesuss closed 9 years ago

kylesuss commented 10 years ago

It took me a while to figure out what values to use for the CONTAINER_PORT and HOST_PORT so I thought an example would be nice.

stuartpb commented 10 years ago

Without any explaining context, two arbitrary numbers don't help to illuminate which value is which or how to use them.

stuartpb commented 10 years ago

If this were to be redone with some explanation of what's being bound to what and why, I'd probably merge it.

kylesuss commented 10 years ago

Cool, that's fair. I've added a more thorough example to the readme. Let me know what you think.

stuartpb commented 10 years ago

That's not right, though, is it? It shows the port in the container already being bound to the host, and then the creation command is all backwards.

What would make more sense would be:

Give the example of a web app that is written to bind to port 5000 (the PORT value used by Dokku).
Create a binding that binds that container's port 5000 to host port 80.