Project Feedback

[stuartpearman]

@KatieMFritz Can you take a look at this? It's hosted here and meets the following criteria:

• [x] At least 3 button elements are included in your page
• [x] When any of the buttons are hovered over (mouseenter event) or clicked on (click event), a unique sound effect will play from an audio element (try the .play() method) -- you may use these drum kit sounds, create ones from this sound effects generator, or use any other sounds that won't hurt/irritate the people who listen to them
• [x] Each button is well-labeled, corresponding to the sound it will play
• [x] All audio elements are invisible (no controls attribute), so that they can only be played with the buttons
• [x] All of your JavaScript is in a separate file ending with .js

[stuartpearman]

Oh, I read "or clicked on" as "and clicked on", hence each drum having 2 event listeners.

[stuartpearman]

Actually, now that I'm reading it again, I'm not sure whether we're supposed to have both, or one of the two.

[KatieMFritz]

Nice work! I like how you structured your javascript. We're meant to do both event listeners, but Erik read it as one. Open to suggestions on how to word it more clearly. 😄

:shipit:

PS Check your indentation settings! Looks like you're using giant tab indentation, not 2-space. There are some Atom tips in the HTML Linting lesson.

[stuartpearman]

Ah, I have been using sublime. I kept checking my atom settings to try and figure out why it was still using 4-space indentation 😖

Thanks Katie!