search

stuartpittaway / diyBMSv4ESP32

diyBMS v4 code for the ESP32 and new controller hardware
Other
186 stars 81 forks source link

PylonTech emulation - battery quantity #189

Closed deekoowee closed 1 year ago

deekoowee commented 1 year ago

Hi, Setting up my new inverter and propably I found battery bank calc error. Seems, that code do not make correct calculation at line 178 and firmware defaults battery banks to 1 at line 183 ?

Hardware/Software Versions Controller version (from PCB): 4.2 Processor: ESP32 Version: e861a254201a9526f29e00371e471e47b71b5a06 Compiled: 2023-03-16T15:45:16.346Z

To Reproduce Steps to reproduce the behavior:

  1. Selected PylonTech emulation with 830Ah capacity at Charge/Discharge configuration.
  2. Inverter site, selected model 3000C as described in code.
  3. Inverter informs only 1 battery bank connected. Changing the battery capacity to 148Ah or 296Ah did not change battery bank amount.
stuartpittaway commented 1 year ago

This is now fixed in release https://github.com/stuartpittaway/diyBMSv4ESP32/releases/tag/Tag-2023-03-29-08-24

Can you try this version, and feedback to me please?

deekoowee commented 1 year ago

I upgraded the controller firmware to 4e72db94af375c391bad47b9b98507b3271b069d

1) upgrade defaults the 'Nominal Battery Capacity' to 280 2) changed back to 830 and inverter 'see' 11 batteries 3) tested the charging and max current is is inverter's top 120A

I would say, that this fix works.

stuartpittaway commented 1 year ago

Thank you for testing