stuckless / sagetv-phoenix-core

Phoenix Core Services for SageTV
Apache License 2.0
2 stars 7 forks source link

Custom views in /userdata/Phoenix/vfs/*.xml don't reload #7

Open bialio opened 7 years ago

bialio commented 7 years ago

This is an issue I've noticed with custom views that have a date related filter. They work for one day, and then after that they return empty until either the client or server (miniclients) is restarted. Then they work for another day.

Similar views that are in x-vfs.xml don't show this behavior. This view for instance always works: view name="phoenix.view.default.nowshowing"

stuckless commented 7 years ago

If you are using the filter-by="date", I think the DateFilter is is broken... I've looked at it, and the date is only updated when the filter is created... but in this filter you need the Date to be updated every time.

I would call onUpdate() before this line...

https://github.com/stuckless/sagetv-phoenix-core/blob/master/src/main/java/sagex/phoenix/vfs/filters/DateFilter.java#L25

That will ensure that the date is updated with every call.

bialio commented 7 years ago

That’s probably it!  I’ll test and letcha know.

On Feb 8, 2017, 3:13 PM -0600, Sean Stuckless notifications@github.com, wrote:

If you are using the filter-by="date", I think the DateFilter is is broken... I've looked at it, and the date is only updated when the filter is created... but in this filter you need the Date to be updated every time. I would call onUpdate() before this line... https://github.com/stuckless/sagetv-phoenix-core/blob/master/src/main/java/sagex/phoenix/vfs/filters/DateFilter.java#L25 That will ensure that the date is updated with every call. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.