search

stuckyb / ontopilot

15 stars 2 forks source link

'imported from' annotations #60

Closed stuckyb closed 7 years ago

stuckyb commented 7 years ago

Should we add IAO 'imported from' annotations to all entities in import modules?

ramonawalls commented 7 years ago

I would say yes. This is particularly helpful if you import a term from an ontology that has a different namespace (e.g., a relation from RO that has a BFO id). You wouldn't want this if you are importing a whole ontology directly, only if you are making a new ontology to import that is a subset of the source.

stuckyb commented 7 years ago

Done, I think.

Here's how it works: If imports are merged into the main ontology, then each imported entity will get an 'imported from' annotation to indicate its original source. If imports are confined to separate OWL files (i.e., import modules), then the entities will not be annotated because in that case, the entire import module has a single annotation indicating the original source, so there is no need to annotate the entities individually.

@ramonawalls, does that strategy make sense? Also, this is all configurable in the settings file, so that merged entity annotations can be disabled if there is a reason to do so.

ramonawalls commented 7 years ago

This sounds great, Brian.

Ramona L. Walls, Ph.D. Senior Scientific Analyst, CyVerse, University of Arizona Research Associate, Bio5 Institute, University of Arizona

On Wed, May 3, 2017 at 11:28 AM, stuckyb notifications@github.com wrote:

Done, I think.

Here's how it works: If imports are merged into the main ontology, then each imported entity will get an 'imported from' annotation to indicate its original source. If imports are confined to separate OWL files (i.e., import modules), then the entities will not be annotated because in that case, the entire import module has a single annotation indicating the original source, so there is no need to annotate the entities individually.

@ramonawalls https://github.com/ramonawalls, does that strategy make sense? Also, this is all configurable in the settings file, so that merged entity annotations can be disabled if there is a reason to do so.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/stuckyb/ontopilot/issues/60#issuecomment-298996106, or mute the thread https://github.com/notifications/unsubscribe-auth/ADKDrsjNfMhlM3JFHqvUQ2ErmODexOjUks5r2MdfgaJpZM4Mmyvm .

stuckyb commented 7 years ago

Okay, great -- closing this, then.