studas / ICMC-assembly-preprocessor

Preprocessor made for ICMC assembly.
GNU General Public License v3.0
0 stars 1 forks source link

Bad python programming practices in variaveis.py (soon to be renamed variables.py) #6

Open gabriel-libardi opened 2 years ago

gabriel-libardi commented 2 years ago

The script should a main function, and the execution should be controlled by an if __name__ == '__main__' block. Furthermore, procedures from the code should be separated in functions, and be properly documented. The code in variaveis.py also has inconsistent style with the code style of preprocessor.py.

lucasgpulcinelli commented 2 years ago

I Agree there are many bad practices in this file, could you work with @matheuspd, the original creator of the script, to fix this?