student-hub / acs-upb-mobile

A mobile application for students at ACS UPB.
MIT License
27 stars 22 forks source link

Improve time interval pickers #282

Open IoanaAlexandru opened 2 years ago

IoanaAlexandru commented 2 years ago

When migrating to Flutter 2 (#195), I made a list of packages we need to replace with null safe equivalents. Among these was interval_time_picker, which I thought we were using in the event time picker.

Turns out, we weren't actually using it, but since I had already started, I added functionality to open a duration picker when tapping the time interval duration on the add event page:

Screenshot 2021-09-19 at 23 42 08

Screenshot 2021-09-19 at 23 43 21

Now initially the colour didn't fit with our app's colour, so I fiddled around with colour schemes to fix it (and I also noticed the time picker colours didn't match either; now they do).

Screenshot 2021-09-19 at 23 45 01

The base branch for this is null_safety_fixes, so this should only be merged once #280 is merged.