select more than 10 filters

student-hub / acs-upb-mobile

A mobile application for students at ACS UPB.

MIT License

27 stars 22 forks source link

select more than 10 filters #320

Closed AndreeaAdascalitei closed 2 years ago

AndreeaAdascalitei commented 2 years ago

-in the filter page, you can select more than 10 filters -delete the warning of max selected nodes

acs-upb-mobile-bot commented 2 years ago

	1 Error
:no_entry_sign:	No pubspec.yaml changes detected. Did you forget to update the version?

	1 Warning
:warning:	No test changes detected. You should usually add at least one test for any new functionality.

For more info on versioning, check out our PR guidelines.

If this is a trivial change that doesn't warrant a test or changelog entry, you can mark it as #trivial in the PR title.

Generated by :no_entry_sign: Danger

IoanaAlexandru commented 2 years ago

Updating the status on this since it's been a while. The filter limit is there for a reason, we can't just remove it. Firebase "in" queries support a maximum of 10 elements (docs). If we want to remove the warning, we need a smarter way to query the db. Closing this for now, it can be re-opened later.