search

student-hub / acs-upb-mobile

A mobile application for students at ACS UPB.
MIT License
27 stars 22 forks source link

When user resets password, the password validation rules are skipped #338

Open stefanp0pa opened 2 years ago

stefanp0pa commented 2 years ago

E.g. When you try to reset password, you can input '123456' . When signing up for the first time, the validation rules work as expected.

stefanp0pa commented 2 years ago

image

This is what happens when you input 1234

Nevertheless, when entering 123456, the system accepts this as a new password (therefore, the mix of letters and digits check fails)

stefanp0pa commented 2 years ago

According to this answer, there is no way to customize the password requirements for Firebase Authenticator. However, implementing your own provider on top of Firebase Authentication would fix this issue.

AdrianMargineanu commented 2 years ago

If there is no way to customise the password from Firebase, we can check the password on the phone, and if the user's password does not match our validation, the app may open a pop up to display the info that the password is not safe so he should change it. And if he agrees to change, the app should open a change password screen.

Aleandro2000 commented 2 years ago

I take this issue! I'm glat to get that! :))