studentquiz / moodle-mod_studentquiz

Moodle-Plugin
GNU General Public License v3.0
38 stars 38 forks source link

Studentquiz: Update css for displaying error form-group #389

Closed JBThong closed 2 years ago

JBThong commented 2 years ago

Hi Tim,

I have created the commit to change the approach CSS in form-group filter. As I have discussed with you, we have no choices in the situation so I have set CSS important but it makes the cibot warning. I think we ignore the cibot warning in this case.

Could you please help me to review it? Thanks

image

dionysius commented 2 years ago

Oh, I could have a look at that as well, but easter is around the corner and I have no development setup ready.

Rule of thumb: the most specific css path wins, so if we add a better path we might get rid of the !important part. But maybe you've already discussed that.

Although this task is impossible if the previous style has already !important, which might be the case.

JBThong commented 2 years ago

Yes, thanks @dionysius,

The align-items-center class has !important CSS. I have discussed with Tim about this. We will back to it after the easter.

Happy Easter!! :))

timhunt commented 2 years ago

If we are going to do !important, then we need to ensure it does not break CI (https://stylelint.io/user-guide/ignore-code/)

However, do we really need to override this? What happens if we just leave the standard Boostrap CSS here?

JBThong commented 2 years ago

Thanks for your feedback, Tim

I have added .path-mod-studentquiz and updated the style lint to ignore the important!

Could you please help me to review it again? Thanks,

timhunt commented 2 years ago

Thanks Thong. Merged.