Closed vuvanhieu143 closed 2 years ago
Thanks Hieu. This looks like a good general approach. (Sorry it took me so long to get to reviewing it.)
I think you have correctly used out_as_local_url everywhere needed. Good.
And, I don't like the direct use of $_GET, but I see this is already done in other parts of StudentQuiz. It would be great to get rid of all that in future, but that is a different issue. Here, we are following an existing pattern in the code, so OK.
So, all good. Merging.
Hi Tim, I have used the base_url to make all the actions in StudentQuiz question bank view have consistent behavior. Most of logic is handle the base_url is in load_questionbank function. Also, I have removed some the unused param like get_filtered_question_ids. I have added changepagesize input because when we have an url like with query params like cmid=1&qperpage=25 and don't have sesskey, it will cause an error.
Could you please take a look at this approach and peer-review it.
Man thanks