Closed vuvanhieu143 closed 2 years ago
Hi @timhunt , Thank you for your changes, I have reviewed and squash into a single commit. I have tested on mysql, mariadb and postgresql. It is working great. Could you please take a look and peer-review again?
Thanks for working on this Hieu. It looks to me that you have coded all the necessary clean-up, and it looks like it should work.
However, as I was reviewing it, I thought I could code some of the queries a bit more neatly, so I tried doing that (particularly because of point 2. below). My extra changes are in https://github.com/timhunt/moodle-mod_studentquiz/commit/wip-upgrade-fixes. (It may just be easier to read the final code, rather than the diff: https://github.com/timhunt/moodle-mod_studentquiz/blob/wip-upgrade-fixes/db/upgrade.php#L990.)
To explain what I did - roughly in order of the changes in the patch, rather than importance.
I hope this is right. Fundamentally, it is a small change on top of what you had worked out.
However, I am not set up to test this. Therefore, please could you:
If they are all good, I think you should squash my changes into yours, so they go in as a single commit. (And, feel free to made any further improvements that you can think of while you do.)
Thanks for your collaboration on this.