Closed vuvanhieu143 closed 1 year ago
Thanks Hieu, the generally looks very good, I think it is doing the right thing, but I only think that after a lot of hard work to understand what the code is doing. So, most of the comments below are about altering the code to make it easier to understand:
mod_studentquiz_set_state
should be `mod_studentquiz\external\set_state (https://github.com/moodle/moodle/commit/1a1939ac29f26ba2972f47fcab5f0d7b0cbc43dc#diff-5b850491f6e95b557e525fc1dfc9591e3b7284b669edd331b746c96a66d17dc6 is a core change that gets it approximagely right)mod_studentquiz_set_state
is not really right. It should be mod_studentquiz_update_question_state
. Do we change it now? (See https://docs.moodle.org/dev/Web_service_API_functions#Naming_convention for the rules)Hi @timhunt , This is ready for peer-review again.
Hi @timhunt This issue is ready for peer review.