search

studentquiz / moodle-mod_studentquiz

Moodle-Plugin
GNU General Public License v3.0
38 stars 37 forks source link

Change Question state (student) #463

Open eLearning-Group opened 12 months ago

eLearning-Group commented 12 months ago

The description says that the question cannot be changed by the author once the status is set to disapproved. However, the state can be set to "changed" by the author and then the question can be changed again. This seems to me an error.

If the question is disapproved it should not be possible to change the state anymore by the author.

Frank-Koch commented 12 months ago

The behaviour is intended. If the teacher sets the status to "approved" or "disapproved" the student cannot alter the quetion. However, if the teacher sets it to "changed" she grants the student the right again to change the question. This might be needed in the course of a discussion betreen teacher and student. After the question got changed, the teacher is expected to review it again and to grant an "approved" or "disapproved".

eLearning-Group commented 12 months ago

Thanks Frank for your answer. I see the intention. But the point is, if the teacher disapprove the question, the student can change the status to "changed" himself and then he can change the question again. This option should not be possible. The student should not be able to change the status.

Frank-Koch commented 12 months ago

I cannot confirm the described behaviour. A student CANNOT change the state of her question, only the teacher can (of course the manager as well). So I guess your student has teachers rights in this course.

eLearning-Group commented 12 months ago

1 Question from Student 2 Disapproved Question View Teacher 3 Disapproved Question View Student 4 Student starts Quiz and sees the Question View Student 5 Student CAN change the state 6 State changed from Student Student and Teacher Rights in the course

My student has no teachers right, please check the screenshots.

Frank-Koch commented 12 months ago

You're right, the student can change the question in the attempt-mode. That's a bug that has to be fixed. The student cannot change the state in the view-mode, which I looked at first. Thank you for pointing out.